-
Notifications
You must be signed in to change notification settings - Fork 114
Minor ipv6-nat64 fixes #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Minor ipv6-nat64 fixes #1020
Conversation
steveb
commented
Mar 4, 2025
- sudo where appropriate
- use full context for chcon calls
- reduce the default of the size of SNO disk from 150G to 31G which aligns with CRC
- sudo where appropriate - use full context for chcon calls - reduce the default of the size of SNO disk from 150G to 31G which aligns with CRC
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hjensas, steveb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bshephar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly seems fine to me. I just wonder how much space is consumed by all of the local-storage PV's for a fully deployed environment on CRC?
Don't want to have some subset of CI jobs failing because they're filling up the 31GB of storage
| VCPUS="${VCPUS:-12}" | ||
| OS_VARIANT="${OS_VARIANT:-fedora-coreos-stable}" | ||
| DISK_SIZE="${DISK_SIZE:-150}" | ||
| DISK_SIZE="${DISK_SIZE:-31}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this possibly going to cause issues for some CI jobs since we use local-storage? Or do we think 31GB should be sufficient for all of our jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to align this with CRC. Jobs will be overriding this value for their requirements where necessary